Enable LLVM 16.0.3 #4411
Enable LLVM 16.0.3 #4411
Conversation
|
Note, 16.0.4 came out after I started this work, but I will update Serpent OS to use latest release and test again there. |
| sudo apt-get install gdb=9.1-0ubuntu1 llvm | ||
| version='${{ matrix.llvm_version }}' | ||
| if [[ "$version" =~ ^1[6-9]\. ]]; then # LLVM 16.0.3+ | ||
| sudo apt-get install gdb llvm llvm-14-tools |
There was a problem hiding this comment.
rather than adding llvm-14-tools, you should copy llvm16's filecheck.cpp to ldc's utils folder
|
Sorry for letting this go stale! Will get back on to it asap! |
Signed-off-by: Ikey Doherty <ikey@serpentos.com>
Signed-off-by: Ikey Doherty <ikey@serpentos.com>
In stable LLVM 16 this is now under `Support` and not `IR` Signed-off-by: Ikey Doherty <ikey@serpentos.com>
The StandardInstrumentations type now takes an LLVMContext parameter so pass it along from the current module. Signed-off-by: Ikey Doherty <ikey@serpentos.com>
Instructions now use friend APIs to add themselves into a BasicBlock, rather than a BasicBlock having an API to add the instructions. Signed-off-by: Ikey Doherty <ikey@serpentos.com>
This was killed upstream in the codegen pipeline as part of a bunch of legacy PM removals: - https://reviews.llvm.org/D137116 Signed-off-by: Ikey Doherty <ikey@serpentos.com>
This isn't *the* most ideal approach and in future we may want to select specific fallbacks other than "generic". Signed-off-by: Ikey Doherty <ikey@serpentos.com>
Unfortunately when building with LLVM < 15, we're using C++-11, so the std::optional bits are only available in C++-17. Even more unfortunately we can't really override this, rather inherit the fact of using C++-17 when using LLVM > 16. Thus, we add a slightly messy conditional compilation situation to allow usage of LDC on older LLVM versions, and with newer LLVM/libcxx. Signed-off-by: Ikey Doherty <ikey@serpentos.com>
Modified to have an explicit `main()` per the other profdata imports in this tree. Signed-off-by: Ikey Doherty <ikey@serpentos.com>
Signed-off-by: Ikey Doherty <ikey@serpentos.com>
|
Rebased. I wanted to leave the CI run so you could see the logs. I'm seeing a bunch of errors, chiefly:
|
|
I just checked, 15 + 16 different significantly re llvm-profdata. Additionally I see a test plugin failure that I need to fix |
|
Thanks Ikey for starting this! |
|
Glad this is in now! Sorry I couldn't do much more on it, kinda hit my domain knowledge with this one :D |
|
Yeah, a bit unlucky with that problematic v16 bump - your work would have sufficed for most other LLVM bumps (excl. v15, but that's an entirely different topic). We'll see pretty soon how v17 goes... |
Each commit in the series explains the rationale behind each decision, but nothing scary really.
The main issue area I have is getting the CI itself to bend to my will, so I could need some help here?
.x- I saw before a nonjanky gdb was forced?Note: due to llvm<16 forcing C++-11 we have to use conditional compilation, otherwise we're trying to
use C++-17 features ..